Migrate cloudbuild connection to mmv1 #9537

trodge · 2023-11-28T23:55:48Z

Migration of cloudbuild connection and repository.

fixes hashicorp/terraform-provider-google#16162

#9631 for repository only

Release Note Template for Downstream PRs (will be copied)

cloudbuildv2: changed underlying actuation engine for `google_cloudbuildv2_connection`, there should be no user-facing impact

modular-magician · 2023-11-30T03:43:51Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudbuildv2Connection_cloudbuildv2ConnectionExample[Debug log]
TestAccCloudbuildv2Connection_GhePrivConnection[Debug log]
TestAccCloudbuildv2Connection_GheCompleteConnection[Debug log]
TestAccCloudbuildv2Connection_GitlabConnection[Debug log]
TestAccCloudbuildv2ConnectionIamBindingGenerated[Debug log]
TestAccCloudbuildv2ConnectionIamMemberGenerated[Debug log]
TestAccCloudbuildv2ConnectionIamPolicyGenerated[Debug log]
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample[Error message] [Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-11-30T21:04:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
TF Conversion: Diff ( 17 files changed, 952 insertions(+), 2607 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-11-30T22:17:00Z

Tests analytics

Total tests: 3254
Passed tests 2910
Skipped tests: 331
Affected tests: 13

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician · 2023-11-30T22:32:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
TF Conversion: Diff ( 12 files changed, 4 insertions(+), 2478 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-11-30T23:45:26Z

Tests analytics

Total tests: 3254
Passed tests 2910
Skipped tests: 331
Affected tests: 13

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

modular-magician · 2023-12-01T00:00:14Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample[Error message] [Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-02T00:08:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
TF Conversion: Diff ( 16 files changed, 952 insertions(+), 2478 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-12-02T01:21:36Z

Tests analytics

Total tests: 3258
Passed tests 2913
Skipped tests: 331
Affected tests: 14

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccGKEHub2Fleet_gkehubFleetBasicExample_update|TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

modular-magician · 2023-12-02T01:47:33Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample[Error message] [Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleConnection[Error message] [Debug log]
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-04T18:21:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2782 insertions(+), 2138 deletions(-))
TF Conversion: Diff ( 13 files changed, 4 insertions(+), 2568 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-12-04T18:33:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2774 insertions(+), 2130 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2774 insertions(+), 2130 deletions(-))
TF Conversion: Diff ( 13 files changed, 7 insertions(+), 2481 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-12-04T19:50:38Z

Tests analytics

Total tests: 3258
Passed tests 2914
Skipped tests: 331
Affected tests: 13

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccLoggingProjectSink_updatePreservesCustomWriter

Get to know how VCR tests work

modular-magician · 2023-12-04T20:05:42Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample[Error message] [Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample[Error message] [Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Error message] [Debug log]
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-12-05T23:45:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2768 insertions(+), 2131 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2768 insertions(+), 2131 deletions(-))
TF Conversion: Diff ( 13 files changed, 4 insertions(+), 2587 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-12-06T00:08:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 21 files changed, 2768 insertions(+), 2131 deletions(-))
Terraform Beta: Diff ( 21 files changed, 2768 insertions(+), 2131 deletions(-))
TF Conversion: Diff ( 3 files changed, 4 insertions(+), 39 deletions(-))
TF OiCS: Diff ( 16 files changed, 498 insertions(+))

modular-magician · 2023-12-06T01:20:33Z

Tests analytics

Total tests: 3262
Passed tests 2915
Skipped tests: 332
Affected tests: 15

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample|TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccDataprocJobIamPolicy|TestAccDataprocClusterIamPolicy|TestAccGKEHub2Fleet_gkehubFleetBasicExample_update

Get to know how VCR tests work

modular-magician · 2023-12-06T01:50:56Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGleExample[Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGithubExample[Debug log]
TestAccCloudbuildv2Repository_cloudbuildv2RepositoryGheExample[Debug log]
TestAccDataprocJobIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccGKEHub2Fleet_gkehubFleetBasicExample_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudBuildTrigger_cloudbuildTriggerRepoExample[Error message] [Debug log]
TestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample[Error message] [Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GheConnection[Error message] [Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2024-01-11T00:58:07Z

Tests analytics

Total tests: 3342
Passed tests 3004
Skipped tests: 337
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocJobIamPolicy

Get to know how VCR tests work

modular-magician · 2024-01-11T01:05:16Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

slevenick

Looks like we've lost several DSFs inside of objects. Does our breaking change checker not catch that? We had a way to detect these things I thought?

mmv1/products/cloudbuildv2/Connection.yaml

modular-magician · 2024-01-16T21:22:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2033 insertions(+), 1494 deletions(-))
Terraform Beta: Diff ( 10 files changed, 2033 insertions(+), 1494 deletions(-))
TF OiCS: Diff ( 4 files changed, 113 insertions(+))

modular-magician · 2024-01-16T22:21:41Z

Tests analytics

Total tests: 3349
Passed tests 3011
Skipped tests: 337
Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

modular-magician · 2024-01-16T22:27:48Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

slevenick · 2024-01-23T18:02:51Z

mmv1/products/cloudbuildv2/Connection.yaml

+    name: annotations
+    description: Allows clients to store small amounts of arbitrary data.
+  - !ruby/object:Api::Type::String
+    name: etag


Was this being used by the DCL during requests? I'm seeing traits that indicate it may have been used

slevenick · 2024-01-23T18:05:40Z

mmv1/products/cloudbuildv2/Connection.yaml

+    skip_test: true
+parameters:
+  - !ruby/object:Api::Type::String
+    name: name


It looks like this was annotated with the long_form trait. Can you add tests on the long form functionality?

modular-magician · 2024-01-23T22:09:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 2052 insertions(+), 1497 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2057 insertions(+), 1497 deletions(-))
TF OiCS: Diff ( 4 files changed, 113 insertions(+))

modular-magician · 2024-01-23T23:08:41Z

Tests analytics

Total tests: 3380
Passed tests 3037
Skipped tests: 337
Affected tests: 6

Click here to see the affected service packages

all service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudbuildv2Connection_GheConnection|TestAccCloudbuildv2Connection_GithubConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GhePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivUpdateConnection

Get to know how VCR tests work

modular-magician · 2024-01-23T23:21:19Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudbuildv2Connection_GheConnection[Debug log]
TestAccCloudbuildv2Connection_GithubConnection[Debug log]
TestAccCloudbuildv2Connection_GleConnection[Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Debug log]
TestAccCloudbuildv2Connection_GhePrivUpdateConnection[Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

slevenick

Can you change the changelog note to be similar to:
cloudbuildv2: changed underlying actuation engine for google_cloudbuildv2_repository, there should be no user-facing impact (hashicorp/terraform-provider-google#16969)

* Migrate cloudbuildv2 connection from DCL to mmv1 * Add conflicts and diff suppress func * Add long form name * Make etag a fingerprint

modular-magician added the service/cloudbuild label Nov 29, 2023

trodge force-pushed the migrate-cloudbuild-connection branch from fec23b0 to f7b7999 Compare November 30, 2023 20:53

trodge force-pushed the migrate-cloudbuild-connection branch from f7b7999 to 9063a6c Compare November 30, 2023 22:22

trodge force-pushed the migrate-cloudbuild-connection branch 2 times, most recently from 7a2e6a0 to 6141e2e Compare December 1, 2023 23:57

GoogleCloudPlatform deleted a comment from modular-magician Dec 1, 2023

slevenick requested changes Jan 16, 2024

View reviewed changes

mmv1/products/cloudbuildv2/Connection.yaml Show resolved Hide resolved

mmv1/products/cloudbuildv2/Connection.yaml Show resolved Hide resolved

mmv1/products/cloudbuildv2/Connection.yaml Show resolved Hide resolved

trodge force-pushed the migrate-cloudbuild-connection branch from 03d876d to a4cf48e Compare January 16, 2024 21:12

trodge requested a review from slevenick January 16, 2024 21:12

trodge assigned trodge and unassigned trodge Jan 16, 2024

slevenick reviewed Jan 23, 2024

View reviewed changes

trodge added 4 commits January 23, 2024 21:42

Migrate cloudbuildv2 connection from DCL to mmv1

40931bb

Add conflicts and diff suppress func

a2b8b2a

Add long form name

4177b43

Make etag a fingerprint

71b2e71

trodge force-pushed the migrate-cloudbuild-connection branch from a4cf48e to 71b2e71 Compare January 23, 2024 21:59

trodge requested a review from slevenick January 24, 2024 23:29

slevenick approved these changes Feb 5, 2024

View reviewed changes

trodge merged commit 046672b into GoogleCloudPlatform:main Feb 8, 2024
12 checks passed

trodge deleted the migrate-cloudbuild-connection branch February 8, 2024 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate cloudbuild connection to mmv1 #9537

Migrate cloudbuild connection to mmv1 #9537

trodge commented Nov 28, 2023 •

edited

Loading

modular-magician commented Nov 30, 2023

modular-magician commented Nov 30, 2023

modular-magician commented Nov 30, 2023

modular-magician commented Nov 30, 2023

modular-magician commented Nov 30, 2023

modular-magician commented Dec 1, 2023

modular-magician commented Dec 2, 2023

modular-magician commented Dec 2, 2023

modular-magician commented Dec 2, 2023

modular-magician commented Dec 4, 2023

modular-magician commented Dec 4, 2023

modular-magician commented Dec 4, 2023

modular-magician commented Dec 4, 2023

modular-magician commented Dec 5, 2023

modular-magician commented Dec 6, 2023

modular-magician commented Dec 6, 2023

modular-magician commented Dec 6, 2023

modular-magician commented Jan 11, 2024

modular-magician commented Jan 11, 2024

slevenick left a comment

modular-magician commented Jan 16, 2024

modular-magician commented Jan 16, 2024

modular-magician commented Jan 16, 2024

slevenick Jan 23, 2024

slevenick Jan 23, 2024

modular-magician commented Jan 23, 2024

modular-magician commented Jan 23, 2024

modular-magician commented Jan 23, 2024

slevenick left a comment

Migrate cloudbuild connection to mmv1 #9537

Migrate cloudbuild connection to mmv1 #9537

Conversation

trodge commented Nov 28, 2023 • edited Loading

modular-magician commented Nov 30, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Nov 30, 2023

Diff report

modular-magician commented Nov 30, 2023

Tests analytics

Action taken

modular-magician commented Nov 30, 2023

Diff report

modular-magician commented Nov 30, 2023

Tests analytics

Action taken

modular-magician commented Dec 1, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 2, 2023

Diff report

modular-magician commented Dec 2, 2023

Tests analytics

Action taken

modular-magician commented Dec 2, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Dec 4, 2023

Diff report

modular-magician commented Dec 4, 2023

Diff report

modular-magician commented Dec 4, 2023

Tests analytics

Action taken

modular-magician commented Dec 4, 2023

modular-magician commented Dec 5, 2023

Diff report

modular-magician commented Dec 6, 2023

Diff report

modular-magician commented Dec 6, 2023

Tests analytics

Action taken

modular-magician commented Dec 6, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Jan 11, 2024

Tests analytics

Action taken

modular-magician commented Jan 11, 2024

Rerun these tests in REPLAYING mode to catch issues

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Jan 16, 2024

Diff report

modular-magician commented Jan 16, 2024

Tests analytics

Action taken

modular-magician commented Jan 16, 2024

Rerun these tests in REPLAYING mode to catch issues

slevenick Jan 23, 2024

Choose a reason for hiding this comment

slevenick Jan 23, 2024

Choose a reason for hiding this comment

modular-magician commented Jan 23, 2024

Diff report

modular-magician commented Jan 23, 2024

Tests analytics

Action taken

modular-magician commented Jan 23, 2024

Rerun these tests in REPLAYING mode to catch issues

slevenick left a comment

Choose a reason for hiding this comment

trodge commented Nov 28, 2023 •

edited

Loading